Answer:1 projection solution #523
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
tomalaforge reviewed Jan 24, 2024
| width="200px" /> | ||
| <ng-content select="[image]"></ng-content> | ||
| <section> | ||
| @for (item of list; track item) { |
Owner
There was a problem hiding this comment.
track: item is a dangerous default track option. You should use it only if the list is not updated (like adding or deleting element) , prefer using a specific property like id
tomalaforge reviewed Jan 24, 2024
| export class CardComponent<T> { | ||
| @Input() list: T[] | null = null; | ||
| @Output() addedItem = new EventEmitter<void>(); | ||
| @ContentChild(CardListItemDirective, { read: TemplateRef }) |
tomalaforge reviewed Jan 24, 2024
| }), | ||
| ), | ||
| { initialValue: [] as City[] }, | ||
| ); |
Owner
There was a problem hiding this comment.
I don't really like this kind of implementation.
Loading the cities just be separate from the state cities.
You should call fetchCities inside the constructor or ngoninit and get the city from the store. More maintainable, easier to read.
Owner
| Great work |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Checklist for challenge submission