Skip to content

Conversation

@svenson95
Copy link
Contributor

Checklist for challenge submission

  • Start your PR message with Answer:${challenge_number}

My solution don't use any css variables. In my opinion it's better to keep the text styling within the text component.

:host-context(.warning) p {
font-size: 25px;
color: orange;
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the goal is to use css variables to be as customizable as possible.

Copy link
Contributor Author

@svenson95 svenson95 Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, removed the @HostBinding('class') in TextStaticComponent as well. It's possible to select the type="error" attribute with [type="error"] { ... } in css.

@tomalaforge tomalaforge added answer answer 13 exercice styling labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

13 exercice styling answer answer

2 participants