Skip to content

Conversation

@freud14-tm
Copy link

What does this do?

Handle value error when we set should_instrument_requests_inprogress and use the provided registry.

Why do we need it?

To fix > Add a description of the problem the feature is trying to solve..

Who is this for?

Add information on what kind of persona the feature is for.

Linked issues

> Add a description of the problem the feature is trying to solve.

@freud14-tm
Copy link
Author

@trallnag Would it possible to run the workflows awaiting for approval and review this? It's a small PR.

@codecov
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.22%. Comparing base (2e1568e) to head (f84e917).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...rc/prometheus_fastapi_instrumentator/middleware.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@ ## master #324 +/- ## ========================================== - Coverage 95.97% 95.22% -0.76%  ========================================== Files 5 5 Lines 373 377 +4 ========================================== + Hits 358 359 +1  - Misses 15 18 +3 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant