This repository was archived by the owner on Feb 18, 2021. It is now read-only.
Honor --attempts command line parameter #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| LGTM |
sloppyfocus added a commit that referenced this pull request Mar 2, 2015
Honor --attempts command line parameter
yashsarma referenced this pull request in lyft/statsrelay Feb 8, 2017
fixes ``` Program received signal SIGSEGV, Segmentation fault. 0x000000000040b7e2 in expiry_callback (_s=0x6870f0, key=0x664cd0 "foo.bar", _value=0x6652f0, metadata=0x0) at /code/statsrelay/src/sampling.c:177 177 if ((now - bucket->last_modified_at) > (*ttl)) { ``` theatrus referenced this pull request in lyft/statsrelay Feb 13, 2017
fixes ``` Program received signal SIGSEGV, Segmentation fault. 0x000000000040b7e2 in expiry_callback (_s=0x6870f0, key=0x664cd0 "foo.bar", _value=0x6652f0, metadata=0x0) at /code/statsrelay/src/sampling.c:177 177 if ((now - bucket->last_modified_at) > (*ttl)) { ``` theatrus referenced this pull request in lyft/statsrelay May 1, 2020
fixes ``` Program received signal SIGSEGV, Segmentation fault. 0x000000000040b7e2 in expiry_callback (_s=0x6870f0, key=0x664cd0 "foo.bar", _value=0x6652f0, metadata=0x0) at /code/statsrelay/src/sampling.c:177 177 if ((now - bucket->last_modified_at) > (*ttl)) { ``` Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
carbonsink.py takes a --attempts parameter, but doesn't do anything with it. This causes it to be honored.
R: @sloppyfocus