Skip to content

in calc_sum added needs.values() as parameter to filter_single_need() #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

in calc_sum added needs.values() as parameter to filter_single_need() #1453

wants to merge 3 commits into from

Conversation

@PhilipPartsch
Copy link
Contributor

@PhilipPartsch PhilipPartsch commented May 7, 2025

try to implement #1452
@PhilipPartsch
Copy link
Contributor Author

PhilipPartsch commented Nov 8, 2025

@ubmarco, @danwos , @chrisjsewell : Could I get a review?
chrisjsewell
chrisjsewell reviewed Nov 8, 2025
View reviewed changes
Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya, I would need to see a good use case of why this is required cheers
@PhilipPartsch
Copy link
Contributor Author

PhilipPartsch commented Nov 9, 2025 •
edited
Loading

The Idea is to have the same filter algorithm as for needtable, needlist, ...
@PhilipPartsch
Copy link
Contributor Author

PhilipPartsch commented Nov 11, 2025

Even the documentation specifies, we can use needs within filter string in calc_sum: https://sphinx-needs.readthedocs.io/en/latest/filter.html#filter-string

So the missing needs are a bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@PhilipPartsch @chrisjsewell