Add timepoint to periodic task settings. #913
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
vazgmik force-pushed the 895-feat-pt-time-point branch 2 times, most recently from 6731cd2 to ed36286 Compare vazgmik force-pushed the 895-feat-pt-time-point branch from ed36286 to b6ee85c Compare vazgmik force-pushed the 895-feat-pt-time-point branch from b6ee85c to e39b5f0 Compare 
segoon reviewed May 14, 2025
| struct Settings final { | ||
| struct TimePoint { | ||
| std::uint8_t hour; | ||
| std::uint8_t minute; |
Collaborator
There was a problem hiding this comment.
если есть что-то про время, должно быть и про таймзону
| struct Settings final { | ||
| struct TimePoint { | ||
| std::uint8_t hour; | ||
| std::uint8_t minute; |
Collaborator
There was a problem hiding this comment.
лучше инициализировать нулями, чем оставлять мусорные значения
| | ||
| /// @brief Time point for the task execution. Task is repeated every | ||
| /// hour:minute UTC of the current/next day | ||
| std::optional<TimePoint> strong_mode_anchor; |
Collaborator
There was a problem hiding this comment.
как-то костыльненько выглядит
у нас есть параметры внутри Settings, и тут они частично переопределяются
лучше написать отдельный класс, который работает по расписанию и не обладает инвариантами PeriodicTask
vazgmik force-pushed the 895-feat-pt-time-point branch from e39b5f0 to 248e505 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Relates #895
Note: by creating a PR or an issue you automatically agree to the CLA. See CONTRIBUTING.md. Feel free to remove this note, the agreement holds.