Skip to content

Conversation

@Slashgear
Copy link
Contributor

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

  • link is a reserved frontmatter key.

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature

For SEO purpose, a Vuepress user should be able to add link tag in head.
For example, user could need to define canonical url.

  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:
Should we add a update-link mixin too ?

Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such changes does not work under dev.

@Slashgear
Copy link
Contributor Author

@ulivz That what i mean with my question about creating a mixin like the existing update-meta one. Should i do it ?

@flozero flozero added status: awaiting more context Need more context about this issue need feedback Awaiting author response complexity: medium Medium complexity topic: plugins Relates to VuePress plugins type: enhancement Request to enhance an existing feature version: 1.x Relates to version 1 of VuePress labels Sep 5, 2019
@ulivz
Copy link
Member

ulivz commented Dec 20, 2021

We're closing this pull request as stale as it's more than 20 days without activity, and without an associated Pull Request. Please feel free to continue discussion. We'll reopen this issue if anything actionable is posted.

@ulivz ulivz closed this Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: medium Medium complexity need feedback Awaiting author response status: awaiting more context Need more context about this issue topic: plugins Relates to VuePress plugins type: enhancement Request to enhance an existing feature version: 1.x Relates to version 1 of VuePress

3 participants