Skip to content

experimental: Ranges animation control #5125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

experimental: Ranges animation control #5125

wants to merge 2 commits into from

Conversation

@istarkov
Copy link
Member

@istarkov istarkov commented Apr 14, 2025 •
edited
Loading

Description

https://6382151c8b47d4399fb9fc69-mgmubxoyek.chromatic.com/?path=/story/builder-components-animationranges--basic

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file
@istarkov
experimental: Ranges animation control
73b275e 
Add border animation Move vars Try ranges
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@istarkov