Skip to content

Conversation

@linkmauve
Copy link

@linkmauve linkmauve commented Oct 30, 2025

Description

This fixes a bunch of typos found by the typos tool.

Would it make sense to add it to the CI in a future PR, to prevent further typos from being added?

Checklist

  • I have reviewed my own code
  • I have added tests (not relevant, plus tests don’t pass currently on master as of 71e24b7)

Edit: they do pass, but only with --features=ssr, otherwise yew::LocalServerRenderer isn’t present and packages/yew/tests/raw_html.rs:51 tries to use it anyway.

@github-actions
Copy link

github-actions bot commented Oct 30, 2025

Benchmark - core

Yew Master

vnode fastest │ slowest │ median │ mean │ samples │ iters ╰─ vnode_clone 2.794 ns │ 3.075 ns │ 2.798 ns │ 2.809 ns │ 100 │ 1000000000 

Pull Request

vnode fastest │ slowest │ median │ mean │ samples │ iters ╰─ vnode_clone 2.796 ns │ 4.048 ns │ 2.801 ns │ 2.889 ns │ 100 │ 1000000000 
@github-actions
Copy link

github-actions bot commented Oct 30, 2025

Visit the preview URL for this PR (updated for commit d084850):

https://yew-rs--pr3937-fix-typos-195b5yc9.web.app

(expires Mon, 24 Nov 2025 19:52:55 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link

github-actions bot commented Oct 30, 2025

Benchmark - SSR

Yew Master

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 270.338 272.592 270.847 0.750
Hello World 10 474.099 495.608 483.133 5.486
Function Router 10 1537.198 1578.957 1563.886 12.814
Concurrent Task 10 1005.429 1007.105 1006.201 0.432
Many Providers 10 1035.235 1079.264 1053.717 15.223

Pull Request

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 270.118 270.883 270.528 0.195
Hello World 10 470.048 482.212 478.954 3.481
Function Router 10 1565.841 1601.421 1584.718 10.571
Concurrent Task 10 1005.522 1007.016 1006.250 0.484
Many Providers 10 1031.795 1068.228 1043.652 12.311
@github-actions
Copy link

github-actions bot commented Oct 30, 2025

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 98.293 98.293 0 0.000%
boids 166.360 166.360 0 0.000%
communication_child_to_parent 91.443 91.443 0 0.000%
communication_grandchild_with_grandparent 102.570 102.570 0 0.000%
communication_grandparent_to_grandchild 98.954 98.954 0 0.000%
communication_parent_to_child 88.812 88.812 0 0.000%
contexts 103.930 103.930 0 0.000%
counter 85.490 85.490 0 0.000%
counter_functional 85.756 85.756 0 0.000%
dyn_create_destroy_apps 88.567 88.567 0 0.000%
file_upload 97.973 97.973 0 0.000%
function_delayed_input 91.064 91.064 0 0.000%
function_memory_game 169.377 169.377 0 0.000%
function_router 328.482 328.482 0 0.000%
function_todomvc 161.589 161.589 0 0.000%
futures 237.045 237.045 0 0.000%
game_of_life 103.772 103.772 0 0.000%
immutable 192.979 192.979 0 0.000%
inner_html 79.967 79.967 0 0.000%
js_callback 107.517 107.517 0 0.000%
keyed_list 179.137 179.137 0 0.000%
mount_point 83.184 83.184 0 0.000%
nested_list 112.698 112.698 0 0.000%
node_refs 90.832 90.832 0 0.000%
password_strength 1743.742 1743.742 0 0.000%
portals 92.308 92.308 0 0.000%
router 301.979 301.979 0 0.000%
suspense 111.685 111.685 0 0.000%
timer 88.160 88.160 0 0.000%
timer_functional 95.892 95.892 0 0.000%
todomvc 141.685 141.685 0 0.000%
two_apps 85.342 85.342 0 0.000%
web_worker_fib 132.882 132.882 0 0.000%
web_worker_prime 184.802 184.802 0 0.000%
webgl 82.523 82.523 0 0.000%

✅ None of the examples has changed their size significantly.

WorldSEnder
WorldSEnder previously approved these changes Nov 1, 2025
Copy link
Member

@WorldSEnder WorldSEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, catches a nice number of typos.
Note that we have some spell checking in ci for markdown documents as a stopgap which relies on a custom dictionary.

Did you run into any false positives and if so, is there a way to disable that for (brand) names and similar?

It makes typos ignore two syllabes files, and one non-typo in a file.
This works on all files instead of just the Markdown files, and already found many issues aspell missed.
@linkmauve
Copy link
Author

Looks good, catches a nice number of typos. Note that we have some spell checking in ci for markdown documents as a stopgap which relies on a custom dictionary.

I’ve now replaced this CI pass with a typos pass, to catch issues in all files instead of just Markdown ones, and removed the aspell shell script.

Did you run into any false positives and if so, is there a way to disable that for (brand) names and similar?

Only "Noo" and "ba", I’ve replaced the first one with "Nooo" to accentuate the effect, and ignored the second. The other false positives are from the syllables.txt files in examples, I’ve ignored the files themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants