Skip to content

autobuild: add working-directory input#1024

Merged
cklin merged 2 commits intogithub:mainfrom
cklin:autobuild-working-dir
Apr 8, 2022
Merged

autobuild: add working-directory input#1024
cklin merged 2 commits intogithub:mainfrom
cklin:autobuild-working-dir

Conversation

@cklin
Copy link
Contributor

@cklin cklin commented Apr 7, 2022

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.
@cklin cklin marked this pull request as ready for review April 7, 2022 17:27
@cklin cklin requested a review from a team as a code owner April 7, 2022 17:27
@cklin
Copy link
Contributor Author

cklin commented Apr 7, 2022

@igfoo Do you have any thoughts on how we should test this functionality?

@cklin cklin requested a review from aeisenberg April 7, 2022 22:32
@aeisenberg
Copy link
Contributor

Looks like a spurious failure.

@aeisenberg
Copy link
Contributor

Best way to test this would be to generate a small test project that uses the autobuild action. Create a workflow that runs codeql on that project and make sure to specify a working directory input. Perhaps something similar to the checkout_path tests.

@igfoo
Copy link
Member

igfoo commented Apr 8, 2022

I've given it a try, and it looks like it works for me; thanks!

@cklin cklin closed this Apr 8, 2022
@cklin cklin reopened this Apr 8, 2022
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@cklin
Copy link
Contributor Author

cklin commented Apr 8, 2022

Finally got PR Check - Autobuild working directory to work:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants