This repository was archived by the owner on Nov 17, 2025. It is now read-only.
Fix event listeners/DOM nodes memory leak and throttle resize events #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…size events Includes: - Unbind 'resize' event handlers on $destroy (as per issue 720kb#143). Not only this reduces the overall number of listeners being bound, but also allows DOM nodes to be GC'ed. - To alleviate some CPU churn, we now throttle the resize event handler. By doing so, we enable users to resize their browsers in a much smoother fashion.
Member
Member
| I'm sorry but I was quite busy at all and, even if I had a clear idea to fix the resize issue (was basically a typo in the code) I forgot to respond. ASAP I'll check, but seems a very good work. |
Member
| @wouldgo 👍 |
Member
| Imho this pr is perfect for merging. |
Member
| Ok ! |
Member
| everything looks fine from some test 📦 shipped https://github.com/720kb/angular-tooltips/releases/tag/1.1.1 Thank you a lot @Omer |
Member
| 👍 |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Includes:
reduces the overall number of listeners being bound, but also allows DOM
nodes to be GC'ed.
doing so, we enable users to resize their browsers in a much smoother
fashion.
Timeline Before:
Timeline After:
Listeners/DOM Nodes/JS Heap Before:
Listeners/DOM Nodes/JS Heap After: