This repository was archived by the owner on Nov 17, 2025. It is now read-only.
Removes http request from caching function, adds additional modifier … #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…in template change function
Member
| Thanks @kmoroder i will release the fix. The lib/ folder is inside the master branch repo, it is not a separated branch ;) |
Member
| You can now try the new version https://github.com/720kb/angular-tooltips/releases/tag/1.1.6 Let me know if everything not working yet or any problem, thank you a lot 👍 |
Contributor Author
| Works great - thanks again! |
Member
| Awesome @kmoroder 💯 |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
@45kb I found my error - I added a second parameter in the tooltipTemplateURLChange function (it was still doing the http request) --- and then I removed the http request in the tooltipTemplateURLCacheChange function (I feel silly for that mistake - that should have never been there). I tested it and it is working now.
Also - I looked for the lib/files branch and couldn't find - so sorry! Thanks!