This repository was archived by the owner on Nov 17, 2025. It is now read-only.
Use !default to declare SCSS variables & make font-sizes configurable #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 2 commits August 10, 2016 13:46
So that the values can be overriden by users of the SCSS file
| Would love to see this land. Anything else that is needed for this? |
Author
| @45kb do you need anything else from me? It would be great if you could merge this in so I don't have to continue to maintain my own fork. There's no functionality/logical changes at all; in theory nothing should work differently for other users. |
Member
| Hi @jogjayr sorry for the delay, i am going to merge this, looks really ok, thank you for your help 👍 |
Member
Author
| Thanks @45kb |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
#177