Skip to content
This repository was archived by the owner on Nov 17, 2025. It is now read-only.

Conversation

@sagivf
Copy link
Contributor

@sagivf sagivf commented May 31, 2015

will add documentation if pull request excepted - thanks :)

@sagivf sagivf mentioned this pull request May 31, 2015
@45kb
Copy link
Member

45kb commented Jun 4, 2015

@sagivf Hi and thanks for the time you spent on it! Unfortunately we can't merge it but i am going to explain you why this.

Actually it is possible to check from inside angular if ngSanitize module is present, so that you can switch in case it is present -> directly ng-bind-html the tooltip-title and tooltip-content, viceversa if ngSanitize is not present.

If you can try something in that way we'll be much glad to merge a new PR, let us know at anytime and thank you a lot anyway!

@45kb 45kb closed this Jun 4, 2015
@sagivf
Copy link
Contributor Author

sagivf commented Jun 5, 2015

Thanks @45kb for the explanation! I agree this is a better solution - when I find the time (maybe in a couple of weeks) I will try to dig into this and add a pull request. If someone else (maybe someone who has done this before) can take this I would be glad to see the issue resolved.

@45kb
Copy link
Member

45kb commented Jun 5, 2015

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants