Skip to content

Support gracefully stopping orchestrator and server #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 6, 2024
Merged

Support gracefully stopping orchestrator and server #6

merged 2 commits into from
Mar 6, 2024

Conversation

@JoeZijunZhou
Copy link
Contributor

@JoeZijunZhou JoeZijunZhou commented Mar 6, 2024

  • Gracefully clean up all threads when stopping the driver
  • Add JetStreamServer as the return of server_lib.run() (when calling stop(), it handles the threads cleanup)
  • Add the orchestrator and server lib unit tests to github action CI
@JoeZijunZhou JoeZijunZhou merged commit 0d7fcf7 into main Mar 6, 2024
@JoeZijunZhou JoeZijunZhou deleted the zijun/unit-tests branch March 6, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@JoeZijunZhou @qihqi