Fix S3 UFS executor service thread leak#15748
Conversation
| | ||
| @Override | ||
| public void close() { | ||
| mExecutor.shutdown(); |
There was a problem hiding this comment.
just want to make sure this mExecutor is not passed in or shared right?
There was a problem hiding this comment.
It is used by the multipart upload. This is a safe shutdown so it will wait for any live tasks that have not finished, but any upload objects that have been created but not yet started will fail.
Actually it looks like the UFS class isn't actually be closed in all places where it is created either, so there might be other things to fix as well.
| Is this one still being worked on? |
| This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions. |
github-actions bot added the stale github-actions bot removed the stale | This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions. |
github-actions bot added the stale | @Jackson-Wang-7 @lucyge2022 mind taking this over? Thanks! |
| LGTM. I'm assuming this is one of the resource leak in ufs @tcrain mentioned in the comment. @jja725
|
| alluxio-bot, merge this please |
| merge failed: |
jja725 added type-feature | alluxio-bot, merge this please |
| alluxio-bot, cherry-pick this to main please |
| Auto cherry-pick unsuccessful Failed to setup local git for auto cherry-pick |
### What changes are proposed in this pull request? Calls shutdown on the executor service in the S3 UFS class. ### Why are the changes needed? If shutdown is not called the threads will not be garbage collected. ### Does this PR introduce any user facing changes? No pr-link: Alluxio#15748 change-id: cid-86d16e80118882044bf529a619b7915c8451eb03
### What changes are proposed in this pull request? Calls shutdown on the executor service in the S3 UFS class. ### Why are the changes needed? If shutdown is not called the threads will not be garbage collected. ### Does this PR introduce any user facing changes? No pr-link: Alluxio#15748 change-id: cid-86d16e80118882044bf529a619b7915c8451eb03
### What changes are proposed in this pull request? Calls shutdown on the executor service in the S3 UFS class. ### Why are the changes needed? If shutdown is not called the threads will not be garbage collected. ### Does this PR introduce any user facing changes? No pr-link: Alluxio#15748 change-id: cid-86d16e80118882044bf529a619b7915c8451eb03
7 participants
What changes are proposed in this pull request?
Calls shutdown on the executor service in the S3 UFS class.
Why are the changes needed?
If shutdown is not called the threads will not be garbage collected.
Does this PR introduce any user facing changes?
No