make connect/open/openSet/disconnect return a promise, fixes #3622 #3790
Conversation
| Thanks 🍻 Btw how's the discussion going over at expressjs/express#2844 ? Looks like you stirred up a hornet's nest over there :) |
make connect/open/openSet/disconnect return a promise, fixes #3622
| hehe, you are welcome I'm not really participating in there. As for me Doug should give a f**k to IBM and its managers whos can bring to the express only one thing - bureaucracy. Fork the project and maintain it as before, instead he removed expressjs/express repo :( so may be my next project will be on koa. |
| Tried using koa but I'm not really a fan yet. I'm sticking with express for now, but also considering forking because of fear of bureaucracy. |
| mongoose@4.4.0 completely broke my production systems because of this change. Why was this not considered a major version change? If not, what is the versioning of Mongoose releases? |
| @Starefossen because AFAIK this shouldn't be backwards breaking - the old callback approach should still work. How did this break your system? |
| This line results in |
| You're right, sorry for the oversight. Will push a 4.4.1 fix for this today. |
3 participants
No description provided.