Move 'tests/functions' to 'tests/http_functions' #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
As suggested by @pragnagopa it would make it easier for us to navigate through the test suite once we have tests for timer- and queue- triggered functions.
Contributor
| Per my offline discussion with Chris and Pragna, we'll do the final code review on merge to master. Merging the current PR for now. |
Collaborator Author
In this case, can we just push to the dev branch directly? Or do you guys want us to create PRs? |
Member
| Let's keep creating PRs - mostly to follow best practices and it will give us a chance to keep an eye on the changes that are going to be merged. |
Collaborator Author
| Yep, agree. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As suggested by @pragnagopa it would make it easier for us
to navigate through the test suite once we have tests for
timer- and queue- triggered functions.