Open
Conversation
github-project-automation bot moved this to In Progress in Azure Service Operator Roadmap Copilot AI changed the title [WIP] Address gosec alerts in mangle-test-json Address gosec alerts in mangle-test-json Mar 20, 2026
theunrepentantgeek requested review from davefellows and matthchr as code owners 
matthchr reviewed Mar 20, 2026
| | ||
| # This is pinned to a particular version of go: | ||
| FROM mcr.microsoft.com/devcontainers/go:1.25 | ||
| FROM mcr.microsoft.com/devcontainers/go:2-1.26 |
Member
There was a problem hiding this comment.
possibly worth a note here explaining what the heck this version is now lol
| analyze: | ||
| name: Analyze (${{ matrix.language }}) | ||
| runs-on: ubuntu-latest | ||
| runs-on: [self-hosted, 1ES.Pool=aso-1es-pool] |
Member
There was a problem hiding this comment.
minor: maybe note why this runs here (due to resources).
| | ||
| - name: Upload release assets | ||
| uses: svenstaro/upload-release-action@04733e069f2d7f7f0b4aebc4fbdbce8613b03ccd # this is v2.9.0, but pinned | ||
| uses: svenstaro/upload-release-action@29e53e917877a24fad85510ded594ab3c9ca12de # this is v2.9.0, but pinned |
Member
There was a problem hiding this comment.
Can't still be 2.9.0 can it? hash changed?
Member
There was a problem hiding this comment.
This is v211.5 - dependabot doesn't recornize that comment format and didn't update the comment. Fixed in #5254
| | ||
| - name: Upload release assets | ||
| uses: svenstaro/upload-release-action@04733e069f2d7f7f0b4aebc4fbdbce8613b03ccd # this is v2.9.0, but pinned | ||
| uses: svenstaro/upload-release-action@29e53e917877a24fad85510ded594ab3c9ca12de # this is v2.9.0, but pinned |
theunrepentantgeek force-pushed the copilot/sub-pr-5220 branch from 3323e6a to da30cc9 Compare theunrepentantgeek changed the base branch from fix/mangle-test-security to main This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gosecflagged unsafe file handling patterns inmangle-test-json. One alert was a genuine path traversal risk; the others were false positives on already-escaped output.os.OpenRoot()to prevent path traversal abusegosecalerts where output is already escaped and the warning doesn't applymainto keep branch currentHow does this PR make you feel?
Checklist
📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.