feat(ach): ACH-specific defaults and originator metadata (closes #66)#88
Merged
feat(ach): ACH-specific defaults and originator metadata (closes #66)#88
Conversation
added 4 commits March 9, 2026 21:49
…e and date present (#66) - Add ACH-{trace}-{YYMMDD} format for ACH_CREDIT/ACH_DEBIT when both fields filled - Fall back to MAN-{code}-{timestamp} when trace or effective date missing - Wire workstation to sync reference on ACH trace/effective date input - Add request and controller tests for ACH defaults, fallback, override, preview Made-with: Cursor
- Add company_name and identification_number to TransactionReference - Default ACH batch reference to ACHyymmddhhmmss when blank - Default ACH memo to (Company Name) - (Identification Number) when blank - Wire workstation autofill for batch and memo from originator fields - Persist originator metadata via AchEntryService reference_attributes Made-with: Cursor
- Use ACH trace as memo reference instead of identification number - Skip default when company name or trace is blank Made-with: Cursor
- Prevents 'Reference number has already been taken' when same trace/date used - Format: ACH-{trace}-{YYMMDD}-{HHMMSS} Made-with: Cursor 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ACHyymmddhhmmss, memo{Company Name} - {Reference Number}when blankACH-{trace}-{YYMMDD}-{HHMMSS}to avoid duplicate reference collisionsTest plan
bundle exec rails test test/controllers/transactions_controller_test.rb test/services/transaction_entry/request_test.rbpassesSchema / migration impact
None. Uses existing
transaction_referencestable with new reference types:ach_company_name,ach_identification_number.Financial logic risk
Low. Changes are to operational metadata and defaulting; posting engine behavior unchanged.
Made with Cursor