feat(arrays) subarrays with fixed bounds #100
Conversation
WalkthroughAdds a new datastructures module implementing an algorithm to count subarrays whose minimum equals min_k and maximum equals max_k, with README, tests, and a DIRECTORY entry linking the new problem. Changes
Sequence Diagram(s)sequenceDiagram participant T as Test / Caller participant F as count_subarrays(nums, min_k, max_k) rect rgba(200,240,200,0.4) T->>F: call with nums, min_k, max_k end Note right of F: initialize counters\nlast_min = last_max = last_invalid = -1\nresult = 0 loop iterate nums[i] F->>F: check nums[i] against min_k/max_k alt nums[i] < min_k or nums[i] > max_k F->>F: last_invalid = i else if nums[i] == min_k F->>F: last_min = i else if nums[i] == max_k F->>F: last_max = i end F->>F: add max(0, min(last_min, last_max) - last_invalid) to result end F-->>T: return result Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
datastructures/arrays/subarrays_with_fixed_bounds/README.md (1)
12-22: Minor formatting inconsistency.Line 15 has
≤10^3while line 14 has≤ 10^3(with space). Consider adding a space for consistency:≤ 10^3.-- 2 ≤ nums.length ≤ 10^3 -- 1 ≤ nums[i], minK, maxK ≤10^3 +- 2 ≤ nums.length ≤ 10^3 +- 1 ≤ nums[i], minK, maxK ≤ 10^3datastructures/arrays/subarrays_with_fixed_bounds/test_subarrays_with_fixed_bounds.py (1)
5-56: Good test coverage with room for improvement.The test suite covers key scenarios including edge cases (equal bounds, no matches, mixed values). However, test names like
test_1,test_2are not very descriptive. Consider more meaningful names.For better readability, consider renaming tests to describe what they test:
def test_single_valid_subarray_with_invalid_elements(self): # test_1 logic def test_multiple_overlapping_valid_subarrays(self): # test_2 logic def test_all_elements_equal_to_bounds(self): # test_3 logic def test_no_elements_match_bounds(self): # test_4 logicdatastructures/arrays/subarrays_with_fixed_bounds/__init__.py (1)
18-31: Efficient sliding window implementation.The algorithm correctly uses a single-pass approach to track the last positions of
min_k,max_k, and invalid elements, computing valid subarrays in O(n) time and O(1) space. The logic at line 29 correctly calculates the number of valid subarrays ending at each position.Consider adding input validation for edge cases, though the current implementation handles them implicitly:
def count_subarrays(nums: List[int], min_k: int, max_k: int) -> int: """...""" if not nums or min_k > max_k: return 0 last_min, last_max, last_invalid = -1, -1, -1 count = 0 # ... rest of implementation
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (4)
datastructures/arrays/subarrays_with_fixed_bounds/images/subarrays_with_fixed_bounds_example_four.pngis excluded by!**/*.pngdatastructures/arrays/subarrays_with_fixed_bounds/images/subarrays_with_fixed_bounds_example_one.pngis excluded by!**/*.pngdatastructures/arrays/subarrays_with_fixed_bounds/images/subarrays_with_fixed_bounds_example_three.pngis excluded by!**/*.pngdatastructures/arrays/subarrays_with_fixed_bounds/images/subarrays_with_fixed_bounds_example_two.pngis excluded by!**/*.png
📒 Files selected for processing (4)
DIRECTORY.md(1 hunks)datastructures/arrays/subarrays_with_fixed_bounds/README.md(1 hunks)datastructures/arrays/subarrays_with_fixed_bounds/__init__.py(1 hunks)datastructures/arrays/subarrays_with_fixed_bounds/test_subarrays_with_fixed_bounds.py(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
datastructures/arrays/subarrays_with_fixed_bounds/test_subarrays_with_fixed_bounds.py (1)
datastructures/arrays/subarrays_with_fixed_bounds/__init__.py (1)
count_subarrays(4-31)
🪛 markdownlint-cli2 (0.18.1)
DIRECTORY.md
199-199: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
200-200: Unordered list indentation
Expected: 4; Actual: 6
(MD007, ul-indent)
🔇 Additional comments (4)
DIRECTORY.md (1)
199-200: LGTM - Index entry added correctly.The new subsection is properly placed under "Non Overlapping Intervals" and follows the existing file structure. The static analysis warning about indentation (MD007) reflects a pre-existing pattern in this file rather than an issue introduced by this PR.
datastructures/arrays/subarrays_with_fixed_bounds/README.md (1)
1-11: LGTM - Clear problem description.The documentation provides a clear explanation of the fixed-bound subarray problem with well-defined conditions.
datastructures/arrays/subarrays_with_fixed_bounds/test_subarrays_with_fixed_bounds.py (1)
1-4: LGTM - Clean import structure.The imports are minimal and appropriate for the test module.
datastructures/arrays/subarrays_with_fixed_bounds/__init__.py (1)
1-2: LGTM - Minimal necessary imports.Clean import of typing for type hints.
Describe your change:
Adds an algorithm to count how many subarrays are within the given array that satisfy the fixed bound problem
Checklist:
Fixes: #{$ISSUE_NO}.Summary by CodeRabbit