Allow deselect when renderSelectedChoices enabled#1221
Allow deselect when renderSelectedChoices enabled#1221godismyjudge95 wants to merge 1 commit intoChoices-js:mainfrom
Conversation
Xon left a comment
There was a problem hiding this comment.
Please ensure unit tests and e2e tests are passing.
- An e2e test for each functionality change should also be added. Ideally one each for
text,select-oneandselect-multipleeven if it is testing it doesn't do anything.
This change has a lot of unrelated code churn which complicates git blame. Please rebuild the PR without those changes to preserve git blame
Changes to .js files not matched in the .ts files. The .ts are the canonical source and the .js changes will be discard at the next build. There are significant changes not committed into the .ts
| Когда уже сделайте?!) |
7aff038 to 39ad700 Compare
All tests except the demo-page screenshot test are passing. I am not sure how to resolve that one? Do I need to generate a new screenshot?
I added a test for select-one and select-multiple. Not sure the text one is relevant in this case?
Apologies, this PR was rushed just to see if you'd be open to the idea. The PR should now be much more concise.
This is fixed now. |
Description
Drafting this PR as I am not sure if you would want to follow a different approach. If this looks good I can try to add tests.
There have been a few requests to allow for deselecting items via the dropdown when the
renderSelectedChoicesoption is enabled. #804 #884I ran across this issue myself while needing to keep a multiselect box footprint minimal (it grows to be pretty large when selecting a few options).
This PR has 3 parts:m
renderSelectedChoicesis enabledrenderItemsboolean option to disable the "pills" in the multiselect input to allow one to only select/deselect via the dropdownScreenshots (if appropriate)
Example of having both
renderSelectedChoices: 'always'andrenderItems: falseTypes of changes
Checklist