Harden file_url handling to prevent SSRF and internal data exfiltration#4971
Open
Youssef-SH wants to merge 2 commits intoCloud-CV:masterfrom
Open
Harden file_url handling to prevent SSRF and internal data exfiltration#4971Youssef-SH wants to merge 2 commits intoCloud-CV:masterfrom
Youssef-SH wants to merge 2 commits intoCloud-CV:masterfrom
Conversation
7 tasks
b516669 to 39364c9 Compare f209ff0 to 0ef4f99 Compare …atus_code, headers, raise_for_status)
Contributor Author
| Hi @RishabhJain2018, I added SSRF protection for CI is currently failing, but it looks unrelated to this change (build/dependency side). Would appreciate a review when you have a moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4970
Summary
This PR hardens handling of the
file_urlparameter used during submission processing to prevent Server-Side Request Forgery (SSRF) and unintended access to internal network resources.The previous implementation allowed arbitrary outbound requests based on user-controlled URLs, enabling access to loopback, private, or otherwise non-public network targets.
Changes
file_urlscheme (HTTP/HTTPS only)Result
Testing