Fix test's broken assumption about std::source_location::current().file_name()#15089
Open
stbergmann wants to merge 1 commit intomainfrom
Open
Fix test's broken assumption about std::source_location::current().file_name()#15089stbergmann wants to merge 1 commit intomainfrom
stbergmann wants to merge 1 commit intomainfrom
Conversation
…le_name() (i.e., __FILE__). Test was introduced in d00259d "wsd: support logging the caller's source location" and broke e.g. for my Linux out-of-tree build with > tst-944160-944160 2026-03-18 22:14:41.075637 [ unittest ] TST testLogCaptureCaller (+2181ms): With caller: [|(from ../../online/test/WhiteBoxTests.cpp:1033)|online/test/WhiteBoxTests.cpp:1029]|online/test/WhiteBoxTests.cpp:1034 > tst-944160-944160 2026-03-18 22:14:41.075643 [ unittest ] TST testLogCaptureCaller (+2181ms): ERROR: Assertion failure: Expected to find the parent's source location. Condition: withCaller.find("|(from WhiteBoxTests.cpp:") != std::string::npos|online/test/WhiteBoxTests.cpp:1036 Signed-off-by: Stephan Bergmann <stephan.bergmann@collabora.com> Change-Id: I9b181640f3536c74321ccd3dd93fadbc6ea8ddbb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay