perf: cancel previous contextual toolbars on hide#15129
Open
perf: cancel previous contextual toolbars on hide#15129
Conversation
Contributor
eszkadev commented Mar 20, 2026
eszkadev commented - followup for commit 6af8af6 perf: do not touch DOM on selection message perf: do not touch DOM directly on selection message for contextual toolbar #15093
- we can cancel previous show request on hide
- do not repeat show requests
- followup for commit 5fb1748 sidebar: attach to DOM in task - remove unnecessary arbitrary timer - cancel old task before creating new one Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: I087530c29a8f593182a38514af4193566b8383c1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.