Switched to layoutSubviews for appearance/layout configuration.#158
Open
grigorye wants to merge 1 commit intoDavydLiu:masterfrom
Open
Switched to layoutSubviews for appearance/layout configuration.#158grigorye wants to merge 1 commit intoDavydLiu:masterfrom
grigorye wants to merge 1 commit intoDavydLiu:masterfrom
Conversation
grigorye commented Jun 16, 2019
| if (!self.icon) { | ||
| self.icon = [self drawIconWithSelection:NO]; | ||
| } | ||
| if (!self.iconSelected || [self.iconSelected.accessibilityIdentifier isEqualToString:kGeneratedIconName]) { |
Author
There was a problem hiding this comment.
I'm not actually sure about the removal of [self.icon.accessibilityIdentifier isEqualToString:kGeneratedIconName] and [self.iconSelected.accessibilityIdentifier isEqualToString:kGeneratedIconName] from the conditions, but without it, it triggers infinite loop of layouts, at least when making a snapshot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #157