fix(NavSprite): Repetitive dependency injection and supplementary notes #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
xiejay97 approved these changes Nov 16, 2021
kagol approved these changes Mar 15, 2022
| private render2: Renderer2, | ||
| private cdr: ChangeDetectorRef, | ||
| @Inject(DOCUMENT) private doc: any | ||
| @Inject(DOCUMENT) private document: Document |
Collaborator
There was a problem hiding this comment.
构建会有报错，建议将document类型暂时修改为any或采用其它更好解决方式
Member
There was a problem hiding this comment.
构建会有报错，建议将document类型暂时修改为any或采用其它更好解决方式
@Simplelegant 可以考虑将构建加到PR门禁里，这样PR的作者能够立即知道他自己提交的PR是否能通过构建任务，参考vue-devui的：
pull-request.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
依赖重复和少注释