Fix Context.deserialize() discarding deserialized cost_manager#1959
Open
jnMetaCode wants to merge 1 commit intoFoundationAgents:mainfrom
Open
Fix Context.deserialize() discarding deserialized cost_manager#1959jnMetaCode wants to merge 1 commit intoFoundationAgents:mainfrom
jnMetaCode wants to merge 1 commit intoFoundationAgents:mainfrom
Conversation
model_validate_json() is a classmethod that returns a new instance. Calling it on self.cost_manager and discarding the return value means the deserialized cost data is silently lost. The fix assigns the returned instance back to self.cost_manager. Signed-off-by: JiangNan <1394485448@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Context.deserialize()inmetagpt/context.pyline 127 calls:model_validate_json()is a Pydantic classmethod that creates and returns a new model instance from JSON. Since the return value is discarded, the deserialized cost manager data is silently lost —self.cost_managerretains its original (default) values.Fix
Assign the returned instance:
This means that when a Team is recovered from serialized state, the cost tracking (total_cost, max_budget, etc.) is correctly restored instead of being reset to defaults.