Skip to content

Conversation

@kash-jay
Copy link
Contributor

@kash-jay kash-jay commented Sep 23, 2025

Context

Showing the vault information when a detected secret is found in a vault.


Screenshot 2025-09-23 at 17 54 03

PR check list

  • As much as possible, the changes include tests
  • If the changes affect the end user (new feature, behavior change, bug fix) then the PR has a changelog entry.

Note

Adds vault details to diagnostics when a secret is vaulted, updating types, parser, tests, and utilities.

  • Results Parsing:
    • Show vault information in diagnostic message: type, name, path, and count (with pluralization) when incident.secret_vaulted is true; otherwise show NO.
    • Replace previous single-line "Secret in Secrets Manager" with a multi-line vaultInfo block.
  • Types:
    • Change Incident to a discriminated union adding vaulted properties: vault_type, vault_name, vault_path, vault_path_count when secret_vaulted: true.
  • Tests:
    • Add scanResultsVaulted fixture and new test asserting vault details.
    • Update existing assertion to expect "Secret found in vault: NO".
  • Utils:
    • Add pluralize(num, word) helper and use it for vault locations.

Written by Cursor Bugbot for commit 2179972. This will update automatically on new commits. Configure here.

@kash-jay kash-jay self-assigned this Sep 23, 2025
@kash-jay kash-jay requested a review from a team as a code owner September 23, 2025 16:03
cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

@sevbch sevbch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sevbch
Copy link
Contributor

sevbch commented Sep 24, 2025

Hi @GabrielCousin, it's be great to have a front-end review 👀 on this PR from you! 🙏

cursor[bot]

This comment was marked as outdated.

@kash-jay kash-jay merged commit d9890b2 into main Sep 29, 2025
6 checks passed
@kash-jay kash-jay deleted the kashyapajayasekera/scrt-5903-add-secret-path-and-vault-instance-information-to-vs-code branch September 29, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants