Skip to content

Conversation

@jabubake
Copy link
Contributor

No description provided.

@jabubake jabubake requested a review from lesv September 26, 2017 00:09
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 26, 2017
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit's

```

- Create a push subscription, to send messages to a Google Cloud Project URL such as https://<your-project-id>.appspot.com/push.
The verification token is used to ensure that the end point only handles requests that are sent matching the verification token.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do I get/create a verification token? MacOS X, Windows, and Linux have uuidgen.

@@ -0,0 +1 @@
{"message":{"data":"dGVzdA==","attributes":{},"messageId":"91010751788941","publishTime":"2017-04-05T23:16:42.302Z"}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this used anywhere?

HttpServletRequest request = mock(HttpServletRequest.class);
assertNotNull(System.getenv("PUBSUB_VERIFICATION_TOKEN"));
when(request.getParameter("token"))
.thenReturn(System.getenv("PUBSUB_VERIFICATION_TOKEN"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is good...

when (request.getReader()).thenReturn(reader);
Stream<String> requestBody = Stream.of(
"{\"message\":{\"data\":\"dGVzdA==\",\"attributes\":{},"
+ "\"messageId\":\"91010751788941\",\"publishTime\":\"2017-04-05T23:16:42.302Z\"}}");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kind of old

@lesv lesv merged commit 89c85be into master Sep 26, 2017
@lesv lesv deleted the appengine-pubsub-j8 branch September 26, 2017 17:01
minherz pushed a commit that referenced this pull request Nov 9, 2022
🤖 I have created a release *beep* *boop* --- ## [0.123.0](googleapis/java-errorreporting@v0.122.23...v0.123.0) (2022-05-19) ### Features * add build scripts for native image testing in Java 17 ([#1440](https://github.com/googleapis/java-errorreporting/issues/1440)) ([#865](googleapis/java-errorreporting#865)) ([a679211](googleapis/java-errorreporting@a679211)) ### Dependencies * update dependency com.google.cloud:google-cloud-core to v2.7.1 ([#863](googleapis/java-errorreporting#863)) ([dfba42c](googleapis/java-errorreporting@dfba42c)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.11.0 ([#864](googleapis/java-errorreporting#864)) ([5d90a9d](googleapis/java-errorreporting@5d90a9d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
minherz pushed a commit that referenced this pull request Nov 10, 2022
🤖 I have created a release *beep* *boop* --- ## [0.123.0](googleapis/java-errorreporting@v0.122.23...v0.123.0) (2022-05-19) ### Features * add build scripts for native image testing in Java 17 ([#1440](https://github.com/googleapis/java-errorreporting/issues/1440)) ([#865](googleapis/java-errorreporting#865)) ([a679211](googleapis/java-errorreporting@a679211)) ### Dependencies * update dependency com.google.cloud:google-cloud-core to v2.7.1 ([#863](googleapis/java-errorreporting#863)) ([dfba42c](googleapis/java-errorreporting@dfba42c)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.11.0 ([#864](googleapis/java-errorreporting#864)) ([5d90a9d](googleapis/java-errorreporting@5d90a9d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
minherz pushed a commit that referenced this pull request Nov 10, 2022
🤖 I have created a release *beep* *boop* --- ## [0.123.0](googleapis/java-errorreporting@v0.122.23...v0.123.0) (2022-05-19) ### Features * add build scripts for native image testing in Java 17 ([#1440](https://github.com/googleapis/java-errorreporting/issues/1440)) ([#865](googleapis/java-errorreporting#865)) ([a679211](googleapis/java-errorreporting@a679211)) ### Dependencies * update dependency com.google.cloud:google-cloud-core to v2.7.1 ([#863](googleapis/java-errorreporting#863)) ([dfba42c](googleapis/java-errorreporting@dfba42c)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.11.0 ([#864](googleapis/java-errorreporting#864)) ([5d90a9d](googleapis/java-errorreporting@5d90a9d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
charlieyu1996 pushed a commit that referenced this pull request Nov 11, 2022
…1.2 (#865) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.1` -> `26.1.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.2/compatibility-slim/26.1.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.2/confidence-slim/26.1.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-datacatalog). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTguMSIsInVwZGF0ZWRJblZlciI6IjMyLjE5OC4xIn0=-->
Sita04 pushed a commit that referenced this pull request Nov 11, 2022
…r to v4.4.0 (#865) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.seleniumhq.selenium:selenium-chrome-driver](https://selenium.dev/) ([source](https://togithub.com/SeleniumHQ/selenium)) | `4.3.0` -> `4.4.0` | [![age](https://badges.renovateapi.com/packages/maven/org.seleniumhq.selenium:selenium-chrome-driver/4.4.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.seleniumhq.selenium:selenium-chrome-driver/4.4.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.seleniumhq.selenium:selenium-chrome-driver/4.4.0/compatibility-slim/4.3.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.seleniumhq.selenium:selenium-chrome-driver/4.4.0/confidence-slim/4.3.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-recaptchaenterprise). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNTAuNCIsInVwZGF0ZWRJblZlciI6IjMyLjE1MC40In0=-->
Sita04 pushed a commit that referenced this pull request Nov 15, 2022
…r to v4.4.0 (#865) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.seleniumhq.selenium:selenium-chrome-driver](https://selenium.dev/) ([source](https://togithub.com/SeleniumHQ/selenium)) | `4.3.0` -> `4.4.0` | [![age](https://badges.renovateapi.com/packages/maven/org.seleniumhq.selenium:selenium-chrome-driver/4.4.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.seleniumhq.selenium:selenium-chrome-driver/4.4.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.seleniumhq.selenium:selenium-chrome-driver/4.4.0/compatibility-slim/4.3.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.seleniumhq.selenium:selenium-chrome-driver/4.4.0/confidence-slim/4.3.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-recaptchaenterprise). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNTAuNCIsInVwZGF0ZWRJblZlciI6IjMyLjE1MC40In0=-->
Sita04 pushed a commit that referenced this pull request Feb 7, 2023
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

3 participants