Skip to content

Conversation

@khokharnikunj8
Copy link
Contributor

@khokharnikunj8 khokharnikunj8 commented Mar 15, 2022

Description

Fixes b/223364117
The DAG is now able to perform cleanup operation on airflow databases with larger data in a single table.
More context : http://docs/document/d/1eWydWjGXqqQ4lvACOMs5o7qQtnuuyo_0jzwWXJ3_YfY?resourcekey=0-TBb9afCO5cWD5hhW_sRZgQ
Note: It's a good idea to open an issue first for discussion.

Checklist

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Mar 15, 2022
@khokharnikunj8 khokharnikunj8 marked this pull request as ready for review March 15, 2022 00:22
Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing for sample reviewers. Please fix the lint error as well.

@leahecole
Copy link
Collaborator

Please give python-samples-reviewers@ access to the doc with context.

Also, does this affect only Airflow 1, or do we need to make these changes in https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/composer/workflows/airflow_db_cleanup.py as well?

@khokharnikunj8
Copy link
Contributor Author

Please give python-samples-reviewers@ access to the doc with context.

Also, does this affect only Airflow 1, or do we need to make these changes in https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/composer/workflows/airflow_db_cleanup.py as well?

Hi, Currently we aim to fix the script for Airflow version 1. We will soon update the script for Airflow version 2 in the later phases.

Gave access to the document to python-samples-reviewers@.

Thanks!

Copy link
Collaborator

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If @dandhlee 's concerns are addressed, LGTM

@leahecole leahecole requested a review from dandhlee March 17, 2022 22:02
Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last edit!

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>
Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leahecole leahecole added the automerge Merge the pull request once unit tests and other checks pass. label Mar 21, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 63d1e3d into GoogleCloudPlatform:main Mar 21, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

3 participants