Skip to content

Enable SVG import destination options when dragging into canvas#3281

Draft
kanishk6103 wants to merge 4 commits intoGraphiteEditor:masterfrom
kanishk6103:improved-svg-import-ux
Draft

Enable SVG import destination options when dragging into canvas#3281
kanishk6103 wants to merge 4 commits intoGraphiteEditor:masterfrom
kanishk6103:improved-svg-import-ux

Conversation

@kanishk6103
Copy link

Closes #3253

@kanishk6103 kanishk6103 marked this pull request as ready for review October 13, 2025 19:23
@kanishk6103
Copy link
Author

Here is a video demo of the included changes:

2025-10-16.21-10-43_muted.mp4

@KeatonTech @timon-schelling

@TrueDoctor
Copy link
Member

Here is a video demo of the included changes:
2025-10-16.21-10-43_muted.mp4

I think you meant to ping @Keavon

@TrueDoctor
Copy link
Member

Also we should probably zoom in on the imported svg once it is loaded right? similar to how that is done when creating a new document

@Keavon
Copy link
Member

Keavon commented Oct 17, 2025

I can't review it yet but as a quick note, please use Title Case in menus.

@timon-schelling
Copy link
Member

timon-schelling commented Oct 18, 2025

Note, Drag events are not forwarded to CEF on desktop (and I would prefer keeping it that way), this will basically not work on desktop.
And other images files should work the same way.

A better flow would be:

  • Frontend (desktop or web) receives a file drop and sends a OpenImportDialogMessage
  • Editor responds with the corresponding dialog layout.
  • User selects new document or new layer from the dialog (maybe cancel could be an option).
  • Editor sends a import file message with a flag set for new document or new layer (or enum)
  • Frontend reads file and responds with a import file message passing along the new document flag.

This should also include unifying import via menu and via file drop.

@kanishk6103
Copy link
Author

Note, Drag events are not forwarded to CEF on desktop (and I would prefer keeping it that way), this will basically not work on desktop. And other images files should work the same way.

A better flow would be:

  • Frontend (desktop or web) receives a file drop and sends a OpenImportDialogMessage
  • Editor responds with the corresponding dialog layout.
  • User selects new document or new layer from the dialog (maybe cancel could be an option).
  • Editor sends a import file message with a flag set for new document or new layer (or enum)
  • Frontend reads file and responds with a import file message passing along the new document flag.

This should also include unifying import via menu and via file drop.

oh, I understand, valid points. I'll try implementing this flow and make the required changes.

@Keavon Keavon changed the title improved svg import ux Enable SVG import destination options when dragging into canvas Oct 19, 2025
@adamgerhant
Copy link
Collaborator

Any update on this @kanishk6103? Ill be marking this as a draft in the mean time

@adamgerhant adamgerhant marked this pull request as draft January 15, 2026 22:00
@kanishk6103
Copy link
Author

Any update on this @kanishk6103? Ill be marking this as a draft in the mean time

Hey, I wasn't able to work on that yet, but I've got some spare time now so I'll work on it.

@kanishk6103 kanishk6103 force-pushed the improved-svg-import-ux branch from 7f5b0c1 to 7842bc2 Compare January 16, 2026 13:50
@Keavon Keavon force-pushed the master branch 6 times, most recently from d6228da to e58c1de Compare March 16, 2026 23:03
@Keavon Keavon force-pushed the master branch 5 times, most recently from 9b97ab7 to 2e842cb Compare March 19, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants