Skip to content

Improve wire path in progress#3460

Draft
adamgerhant wants to merge 3 commits intomasterfrom
improve-wire-path-in-progress
Draft

Improve wire path in progress#3460
adamgerhant wants to merge 3 commits intomasterfrom
improve-wire-path-in-progress

Conversation

@adamgerhant
Copy link
Collaborator

@adamgerhant adamgerhant commented Dec 10, 2025

Improves various data types and code organization for translation between the editor and frontend. Fixes the in progress wire to stay vertical if dragged between layers.

Depends on #3451

chrome_OWQDkbwIKN.mp4
@adamgerhant adamgerhant changed the base branch from master to improve-definitions December 10, 2025 03:19
@github-actions github-actions bot temporarily deployed to graphite-dev (Preview) December 10, 2025 03:23 Inactive
Base automatically changed from improve-definitions to master January 13, 2026 07:09
@adamgerhant adamgerhant force-pushed the improve-wire-path-in-progress branch from 373442f to 44446e4 Compare January 16, 2026 07:43
@github-actions github-actions bot temporarily deployed to graphite-dev (Preview) January 16, 2026 07:47 Inactive
@Keavon
Copy link
Member

Keavon commented Jan 16, 2026

  • Needs to not keep the state from the last time you dragged a wire, needs to reset it when you start dragging every time
  • Needs to not become a thick wire if the wire is coming from a layer's top output that has more than one wire output
@Keavon Keavon marked this pull request as draft January 16, 2026 08:03
@github-actions github-actions bot temporarily deployed to graphite-dev (Preview) January 16, 2026 08:07 Inactive
@Keavon Keavon force-pushed the master branch 6 times, most recently from d6228da to e58c1de Compare March 16, 2026 23:03
@Keavon Keavon force-pushed the master branch 5 times, most recently from 9b97ab7 to 2e842cb Compare March 19, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants