Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the old, limited filters with a new single filter allowing to specify an arbitrarily complex Berkeley Packet Filter program.
This filter is applied directly to the PCAP source, hence it does the filtering at lower level without the need for Sniffnet itself to match packets against filters.
This improves performance with the drawback of losing information about the number of filtered-out packets.
In fact, PCAP doesn't offer a reliable API to see the filtered out-packets; from
pcap_statmanual page:This PR also considerably renews and simplifies the app’s initial page.
bpf.mp4
Fixes #810.