Fix an issue that charging via usb port will close ble#681
Open
L1cardo wants to merge 1 commit intoHaoboGu:mainfrom
Open
Fix an issue that charging via usb port will close ble#681L1cardo wants to merge 1 commit intoHaoboGu:mainfrom
L1cardo wants to merge 1 commit intoHaoboGu:mainfrom
Conversation
Binary Size Reportuse_config/nrf52832_bleDiffuse_config/nrf52840_bleDiffuse_config/nrf52840_ble_splitDiffCentral DiffPeripheral Diffuse_rust/nrf52840_ble_splitDiffCentral DiffPeripheral Diffuse_config/pi_pico_w_bleDiffuse_config/pi_pico_w_ble_splitDiffCentral DiffPeripheral Diffuse_rust/pi_pico_w_ble_splitDiffCentral DiffPeripheral Diffuse_config/rp2040Diffuse_config/rp2040_splitDiffCentral DiffPeripheral Diffuse_rust/rp2040_splitDiffCentral DiffPeripheral Diffuse_config/stm32f1Diffuse_config/stm32f4Diffuse_config/stm32h7Diff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current implementation, as long as the USB cable is plugged in and voltage (VBUS) is detected, the enabled callback will trigger and emit the USB_ENABLED signal, which causes the keyboard to try to switch to USB mode and turn off Bluetooth regardless of whether it is connected to a computer or a charger.
My solution is to move the timing of triggering the USB_ENABLED signal from enabled (only powered on) to configured (the computer host has configured the device).
This way:
目前的实现中，只要USB 线插入并检测到电压（VBUS），enabled 回调就会触发并发出 USB_ENABLED 信号，这导致键盘无论连接的是电脑还是充电器，都会尝试切换到 USB 模式并关闭蓝牙。
我的方案是将触发 USB_ENABLED 信号的时机从 enabled（仅通电）移动到 configured（电脑主机已配置设备）。
这样：
1.连接充电器时：只会触发 enabled，不会发出 USB_ENABLED信号，键盘将保持蓝牙连接或继续广播。
2. 连接电脑时：主机会配置设备，触发 configured，发出 USB_ENABLED信号，键盘场换到 USB 模式。