Conversation
nilmerg requested changes Jun 28, 2023
Member
nilmerg left a comment
nilmerg left a comment There was a problem hiding this comment.
The event should be fired on the new column and include the id of the source column.
So that event.target.id === 'col2' && source === 'col1' is true if col1 content has moved to col2.
- Param1 is the event itself (event.target.id == #col where the content is moved) - Param2 is the soucre col id, form which the content is moved
sukhwinder33445 force-pushed the add-js-event-column-moved branch from de96b6e to 9a41a18 Compare nilmerg added a commit to Icinga/icingadb-web that referenced this pull request Jul 11, 2023
resolves #106 ## blocked by: - Icinga/icingaweb2#5049
nilmerg approved these changes Sep 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.