Some changes to hypot #15649
Merged
Some changes to hypot #15649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
test/math.jl Outdated
| @test isinf(log1p(-one(T))) | ||
| @test isnan(log1p(convert(T,NaN))) | ||
| @test_throws DomainError log1p(convert(T,-2.0)) | ||
| @test hypot(T(0), T(0)) == T(0) |
Contributor
There was a problem hiding this comment.
=== to test for type equality too?
Member Author
There was a problem hiding this comment.
Yes. Just did that.
| end | ||
| if x == 0 | ||
| r = y/one(x) | ||
| if ax == 0 |
Contributor
There was a problem hiding this comment.
is comparing to 0 sufficient or do we need if ax == zero(ax) ?
Member
There was a problem hiding this comment.
For comparisons, you don't need to call zero. It's only useful when you want a specific type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Following up on #15552.
hypot. On my MacBook it is more that 2x faster than the libm version.hypot. This supersedes Extend hypot to 1-arg, 3-arg and varargs #15552.(just realized that doc update is missing. I'll push that tomorrow.)