Merged
Conversation
djones6 force-pushed the issue.swift5 branch from 18211db to c259126 Compare 
ianpartridge approved these changes Nov 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Swift 5, and also removes support for Swift 3:
Package.swiftandPackage.pins,Package@swift-4.swift->Package.swift,swift-DEVELOPMENT-SNAPSHOT-2018-11-22-a)The swift development snapshot is defined as a Travis environment variable
SWIFT_DEVELOPMENT_SNAPSHOT, rather than being hard-coded into the .travis.yml, so that we can automate updates to the snapshot via the Travis API rather than having to push new commits.I am proposing that we drop Swift 3 support as we are otherwise required to maintain additional
Package@swift-n.swiftfiles, and Travis configuration that is out of line with the rest of the Kitura repos. We should tag this as a new minor release, to provide anyone who really does need to remain on Swift 3 a means to continue pulling LoggerAPI at the current (1.7) release with standard SPM syntax.