remove shaking phone as trigger for presentDebugMenu#2149
Merged
ps2 merged 1 commit intoLoopKit:devfrom Apr 24, 2024
Merged
Conversation
Contributor
| Thanks for flagging this. I'll confirm that I accidentally trigger this almost daily, in normal use, so I'm in favor of making it harder to trigger accidentally. |
Contributor Author
| I tested this with a test phone.
|
| Thanks hope it gets approved, that has been a nuisance |
| It worked, thank you |
gestrich added a commit to gestrich/Loop that referenced this pull request May 3, 2024
… so no need to cherry-pick this the next time I build
gestrich added a commit to gestrich/LoopWorkspace that referenced this pull request May 3, 2024
…o dev so no need to cherry-pick this the next time I build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is too easy to trigger the debug menu during daily phone use now that allowDebugFeatures is enabled for DIY loop.
Remove the shaking option, but keep the rotate phone between landscape and portrait 6 times with no more than 2 sec between rotations.