[WIP] Prevent a vm or template being its own parent#23302
Open
agrare wants to merge 2 commits intoManageIQ:masterfrom
Open
[WIP] Prevent a vm or template being its own parent#23302agrare wants to merge 2 commits intoManageIQ:masterfrom
agrare wants to merge 2 commits intoManageIQ:masterfrom
Conversation
agrare force-pushed the fix_genealogy_self_parent branch from 5938445 to 0528763 Compare 
Member Author
| @miq-bot cross-repo-test /providers |
miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Jan 10, 2025
From Pull Request: ManageIQ/manageiq#23302
Fryguy reviewed Jan 10, 2025
app/models/manageiq/providers/inventory/persister/builder/cloud_manager.rb Outdated Show resolved Hide resolved
agrare force-pushed the fix_genealogy_self_parent branch from 0528763 to 01ece9e Compare 
Contributor
| Hi @agrare, I used the changes you committed in this PR, but again i got the same error. What is the work around for this to fix this issue |
Member Author
| @Dhamo1107 thank you for testing! It sounds like we need some more logging / diagnostics to try to find which image or images have this issue. I'll add some more logging to this save block and the openstack parser to try to help find the issue. |
Contributor
| Okay @agrare |
Contributor
How to fix this issue @agrare |
Member Author
| I'm working on it @Dhamo1107 😉 Based on the openstack parser it isn't clear to me how a template could be assigned itself as a genealogy parent because it is only looking at the vms collection so it couldn't even find itself in the database. |
Contributor
| Thank you @agrare, Any work around for this, because not able to do refresh relationship for that provider |
Member Author
| You can comment out the inventory collection temporarily: https://github.com/ManageIQ/manageiq-providers-openstack/blob/master/app/models/manageiq/providers/openstack/inventory/persister/definitions/cloud_collections.rb#L36C27-L36C55 Similar effect to what was being done here: ManageIQ/manageiq-providers-openstack#862 (comment) |
Member Author
| Okay @Dhamo1107 can you try testing out the latest updates in this PR, un-comment the collection in the openstack persister if you commented it out, and try applying the changes here https://github.com/ManageIQ/manageiq-providers-openstack/pull/899/files |
Member
| Checked commits agrare/manageiq@01ece9e~...9c752cd with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
Member
| This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
1 similar comment
Member
| This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent a vm or template from being assigned as its own parent, preventing the ancestry "cannot be a descendant of itself" exception
Fixes ManageIQ/manageiq-providers-openstack#862