Skip to content

Error when hidding keyboard and using Navigation extension#200

Merged
Mottie merged 3 commits intoMottie:masterfrom
jmsanzg:master
Oct 7, 2013
Merged

Error when hidding keyboard and using Navigation extension#200
Mottie merged 3 commits intoMottie:masterfrom
jmsanzg:master

Conversation

@jmsanzg
Copy link
Contributor

@jmsanzg jmsanzg commented Aug 26, 2013

When keyboard is being hidden, a call to navigation extension checkKeys() method is made but with an undefined key. That's the way to detect base.$keyboard doesn't exist and return instead of throwing an exception

When hidding the keyboard a new call is made to checkKeys with an undefined key. That's the way to detect the keyboard is or has been hidden
@Mottie
Copy link
Owner

Mottie commented Sep 10, 2013

I would merge this, but there isn't a guarantee that undefined is really undefined. I tend to use typeof(key) === "undefined". I know that doesn't compress well.

If you make that change, I'll merge it when I have some more internet time.

Updated as requested by original coder Rob G
Mottie added a commit that referenced this pull request Oct 7, 2013
Error when hidding keyboard and using Navigation extension
@Mottie Mottie merged commit b3934e4 into Mottie:master Oct 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants