Skip to content

New setting "closeByClickEvent" implemented #476

Merged
Mottie merged 1 commit intoMottie:masterfrom
SeeeD:master
Aug 12, 2016
Merged

New setting "closeByClickEvent" implemented #476
Mottie merged 1 commit intoMottie:masterfrom
SeeeD:master

Conversation

@SeeeD
Copy link

@SeeeD SeeeD commented Aug 12, 2016

The new setting "closeByClickEvent" should prevent closing the keyboard on "touchstart" and "mousedown".
This will allow the user to scroll the user during the keyboard is open.

@Mottie
Copy link
Owner

Mottie commented Aug 12, 2016

Hi @SeeeD!

Hmm, I was going to say that the userClosed option should do the same thing as this and point to the documentation, but it appears I never added it to the docs!

Please try the demo mentioned here: #415 (comment)

If that behaves the same as this option, please let me know.

@SeeeD
Copy link
Author

SeeeD commented Aug 12, 2016

Hi @Mottie,

thanks for you reply. I will have a look if this option will do the trick. 👍

@Mottie
Copy link
Owner

Mottie commented Aug 12, 2016

Thanks! And I just finished adding the option to the docs: https://github.com/Mottie/Keyboard/wiki/Usability#userclosed

@SeeeD
Copy link
Author

SeeeD commented Aug 12, 2016

Hi @Mottie,
this does not work for me. :(
If I am testing the jsfiddle linked in #415 I will get the same issue. Clicking outside should close the keyboard, but scrolling should be possible too on touch mode (I am using this keyboard on a touch-device without built in keyboard).

Edit:
I am not getting the same issue, sorry. If I am clicking outside the keyboard should close, but it should not close if I am scrolling with my fingers. :) Do you know how I mean?

@Mottie
Copy link
Owner

Mottie commented Aug 12, 2016

Hmm, ok. I'll look into this when I get some time later today.

@Mottie Mottie merged commit 8884c4b into Mottie:master Aug 12, 2016
@Mottie
Copy link
Owner

Mottie commented Aug 12, 2016

Ok, I'll go ahead and add this option. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants