if there have 2 different custom layouts, the second one won't be built.#494
Merged
Mottie merged 1 commit intoMottie:masterfrom Nov 27, 2016
Merged
if there have 2 different custom layouts, the second one won't be built.#494Mottie merged 1 commit intoMottie:masterfrom
Mottie merged 1 commit intoMottie:masterfrom
Conversation
Owner
| Hi @ohohyeah! Sorry for taking so long to respond! That looks like a great fix, thanks! |
Contributor Author
| Thanks, It’s my pleasure to contribute to this awesome project 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have problem with 2 custom keyboard layouts with scramble , there is the detail. (Issue).
I trace the code that it will create the keyboard in this block in the jquery.keyboard.js
and it will go to the jquery.keyboard.extension-scramble.js to create the scrambled keyboard,
however, the "base.orig_layout" in jquery.keyboard.extension-scramble.js is "custom", not the layout named with scrambledXXXX, so the code woun't enter the block to build keyboard
I consider that the check of $.keyboard.builtLayouts[base.orig_layout] should be removed in the "jquery.keyboard.extension-scramble.js", because it will check whether the keyboard layout exists in the " jquery.keyboard.js".
My problem is resolved after remove this, and share for you review.
Thank you!