transport: Replace std::vector with arrays in proxy put-signal API#38
Open
a-szegel wants to merge 1 commit intoNVIDIA:develfrom
Open
transport: Replace std::vector with arrays in proxy put-signal API#38a-szegel wants to merge 1 commit intoNVIDIA:develfrom
a-szegel wants to merge 1 commit intoNVIDIA:develfrom
Conversation
Replace std::vector usage in put-signal host proxy transport API with pre-allocated C arrays to eliminate dynamic memory allocation overhead. The previous implementation used std::vector because the number of writes per put-signal operation varied based on buffer mapping across memory regions. This change pre-allocates fixed-size arrays (max 256 writes) during proxy initialization, providing a small latency improvement for put-signal operations. Signed-off-by: Seth Zegelstein <szegel@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace std::vector usage in put-signal host proxy transport API with pre-allocated C arrays to eliminate dynamic memory allocation overhead. The previous implementation used std::vector because the number of writes per put-signal operation varied based on buffer mapping across memory regions. This change pre-allocates fixed-size arrays (max 256 writes) during proxy initialization, providing a small latency improvement for put-signal operations.