Skip to content

Add AFN network builder script#9516

Draft
jasondegraw wants to merge 2 commits intodevelopfrom
afn-network-builder
Draft

Add AFN network builder script#9516
jasondegraw wants to merge 2 commits intodevelopfrom
afn-network-builder

Conversation

@jasondegraw
Copy link
Member

Pull request overview

Add a script to build out a basic AirflowNetwork model. Draft for now, need to add quite a lot more in terms of documentation and support.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs
I won't force push but I thought about really hard
@nrel-bot
Copy link

@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated.

1 similar comment
@nrel-bot-3
Copy link

@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated.

@Myoldmopar Myoldmopar added this to the EnergyPlus 23.1 milestone Sep 22, 2022
@nrel-bot-2
Copy link

@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated.

4 similar comments
@nrel-bot-2c
Copy link

@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated.

@nrel-bot
Copy link

@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated.

@nrel-bot
Copy link

nrel-bot commented Feb 9, 2023

@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated.

@Myoldmopar
Copy link
Member

@jasondegraw do you think this will be good for 23.1? Doesn't matter either way, just setting up the review queue and moving things to the right milestone.

@nrel-bot
Copy link

@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated.

1 similar comment
@nrel-bot-2c
Copy link

@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@jasondegraw it has been 8 days since this pull request was last updated.

@nrel-bot-2
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

7 similar comments
@nrel-bot-2b
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2b
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2b
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

@jasondegraw it has been 9 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

1 similar comment
@nrel-bot-2b
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

@jasondegraw it has been 18 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

@jasondegraw it has been 8 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@jasondegraw it has been 10 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@jasondegraw it has been 12 days since this pull request was last updated.

@nrel-bot-2
Copy link

@jasondegraw it has been 20 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@jasondegraw it has been 14 days since this pull request was last updated.

@nrel-bot-2
Copy link

@jasondegraw it has been 24 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

2 similar comments
@nrel-bot-2c
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@mitchute mitchute removed this from the EnergyPlus 24.2 milestone Oct 22, 2025
@nrel-bot-2c
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

11 similar comments
@nrel-bot-2c
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@jasondegraw it has been 8 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

7 similar comments
@nrel-bot-2c
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@jasondegraw it has been 7 days since this pull request was last updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

8 participants