feat(core): add graceful shutdown handling to RetryableInboxOutboxEventPoller #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* test(mikroorm-driver): add comprehensive test suite for MikroORM driver - Set up Vitest with SWC for decorator metadata support - Add test utilities for spinning up isolated NestJS apps with fresh PostgreSQL databases - Add unit tests for MikroOrmInboxOutboxTransportEvent entity - Add unit tests for MikroORMDatabaseDriver (persist, remove, flush, findAndExtendReadyToRetryEvents) - Add unit tests for MikroORMDatabaseDriverFactory (forked entity managers, isolation) - Add integration tests for TransactionalEventEmitter with real database - Fix integer overflow for timestamps by using bigint column type 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * ci: add GitHub workflow for MikroORM driver tests - Add test-mikroorm-driver.yml workflow with PostgreSQL service - Revert @mikro-orm versions to ^6.3.9 as requested 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * fix(ci): build core package before running MikroORM driver tests 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
Fix typo in field name throughout codebase and add database migrations to rename the column from delived_to_listeners to delivered_to_listeners. BREAKING CHANGE: Existing databases require running the new migration to rename the column. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
* fix `npm run build` for all pkgs (vibe-kanban eeb84602) * Done. Updated the paths configuration in `test-core.yml` to match the mikroorm workflow pattern: - Added `branches: [main]` filter for both push and pull_request - Added `package.json` and `package-lock.json` (dependency changes may affect tests) - Added `.github/workflows/test-core.yml` (workflow changes should trigger a run) * Done. Removed `branches: [main]` from both workflows. They'll now trigger on any branch when the relevant paths change.
1. **test-core.yml**: Added a "Type check" step that runs `npm run build` before tests 2. **test-mikroorm-driver.yml**: Added a "Type check MikroORM driver" step that runs `npm run build` on the mikroorm-driver workspace before tests This ensures TypeScript type errors are caught early in CI before tests run, preventing the issue where tests could pass while type errors exist in the code.
…ntPoller Implement OnModuleDestroy lifecycle hook to properly clean up resources during application shutdown: - Unsubscribe from RxJS interval to stop polling - Track in-flight event processing and wait for completion - Add isShuttingDown flag to prevent new processing during shutdown 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
jtomaszewski force-pushed the vk/57d1-add-graceful-shu branch from 530822a to 23d2bee Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
OnModuleDestroylifecycle hook for proper cleanup during application shutdownisShuttingDownflag to prevent new processing during shutdownTest plan
🤖 Generated with Claude Code