Fix #1430 by detecting case when client connect/disconnects before me…#1442
Merged
mattrjacobs merged 1 commit intoNetflix:masterfrom Dec 14, 2016
Merged
Fix #1430 by detecting case when client connect/disconnects before me…#1442mattrjacobs merged 1 commit intoNetflix:masterfrom
mattrjacobs merged 1 commit intoNetflix:masterfrom
Conversation
…fore metrics start getting emitted
mattnelson reviewed Dec 14, 2016
| writer.print("ping: \n\n"); | ||
| // explicitly check for client disconnect - PrintWriter does not throw exceptions | ||
| if (writer.checkError()) { | ||
| throw new IOException("io error"); |
There was a problem hiding this comment.
To avoid the cost of creating and throwing the exception, can you call moreDataWillBeSent.set(false); instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…trics start getting emitted