Merged
Conversation
Contributor
| Doesn't seem any different to me. |
Author
| Hello, I am guessing the code is accessed by multiple threads so the call to the first top.get() may return a non null result but that doesn’t meant that the second call to top.get will return a non null result. Could be that a different thread pop’ed the stack to leave null From: Spencer Gibb [mailto:notifications@github.com] Sent: 31 January 2017 14:02 To: Netflix/Hystrix <Hystrix@noreply.github.com> Cc: Clarke, Peter <Peter.Clarke2@fisglobal.com>; Author <author@noreply.github.com> Subject: Re: [Netflix/Hystrix] Remove possible NPE (#1469) Doesn't seem any different to me. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FNetflix%2FHystrix%2Fpull%2F1469%23issuecomment-276370242&data=01%7C01%7Cpeter.clarke2%40fisglobal.com%7Cbc85de4c8de14945a0ac08d449e1c6ab%7Ce3ff91d834c84b15a0b418910a6ac575%7C0&sdata=i0%2F%2BKKMRoAFnWVdmOX%2BA1i48b4t5x7cp49o7SfyJ2H4%3D&reserved=0>, or mute the thread<https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAYQjRSBjh333KSV-ywIl5mV9Oj3bHVn-ks5rXz7qgaJpZM4Lynl1&data=01%7C01%7Cpeter.clarke2%40fisglobal.com%7Cbc85de4c8de14945a0ac08d449e1c6ab%7Ce3ff91d834c84b15a0b418910a6ac575%7C0&sdata=29dOVV%2BrMXTZ1MJTdfgmD7Pl0RLXqFzdK%2FpvJLjvRIg%3D&reserved=0>. The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you. |
Contributor
| Yeah, this looks like a good change to me. Thanks for the PR @petercla ! If the internal state is getting mutated by a different thread while |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.