Move markCommandExecution after markEvent SUCCESS.#1535
Merged
mattrjacobs merged 2 commits intoNetflix:masterfrom Apr 19, 2017
Merged
Move markCommandExecution after markEvent SUCCESS.#1535mattrjacobs merged 2 commits intoNetflix:masterfrom
mattrjacobs merged 2 commits intoNetflix:masterfrom
Conversation
Contributor Author
| I am impressed that the |
Contributor Author
| The re-build worked https://travis-ci.org/bltb/Hystrix/builds/221340917 |
Contributor
| Nope, that was not intentional. Thanks for the report, and the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mattrjacobs , I am not sure, does this fix a bug introduced some time ago?
Also, again, I am not sure... if
eventNotifier.markCommandExecutionshould actually be invoked after...circuitBreaker.markSuccess();like https://github.com/Netflix/Hystrix/releases/tag/v1.5.2