fix: literal arrays are memcpy-ed instead of stored, non constant arrays are unrolled

compiler/plc_driver/src/pipelines.rs

@@ -295,7 +295,7 @@ impl<T: SourceContainer> BuildPipeline<T> {
  }
 
  pub fn get_default_mut_participants(&self) -> Vec<Box<dyn PipelineParticipantMut>> {
- use participant::InitParticipant;
+ use participant::{ArrayLowerer, InitParticipant};
 
  // XXX: should we use a static array of participants?
  let mut_participants: Vec<Box<dyn PipelineParticipantMut>> = vec![
@@ -312,6 +312,7 @@ impl<T: SourceContainer> BuildPipeline<T> {
  self.context.provider(),
  self.context.should_generate_external_constructors(),
  )),
+ Box::new(ArrayLowerer::new(self.context.provider())),
  ];
  mut_participants
  }

compiler/plc_driver/src/pipelines/participant.rs

@@ -21,6 +21,7 @@ use plc::{
 };
 use plc_diagnostics::diagnostics::Diagnostic;
 use plc_lowering::{
+ array_lowering,
  retain::RetainParticipant,
  {
  control_statement::ControlStatementParticipant, inheritance::InheritanceLowerer,
@@ -245,6 +246,28 @@ impl PipelineParticipantMut for InitParticipant {
  }
 }
 
+pub struct ArrayLowerer {
+ id_provider: IdProvider,
+}
+
+impl ArrayLowerer {
+ pub fn new(id_provider: IdProvider) -> Self {
+ Self { id_provider }
+ }
+}
+
+impl PipelineParticipantMut for ArrayLowerer {
+ fn pre_annotate(&mut self, indexed_project: IndexedProject) -> IndexedProject {
+ let IndexedProject { project: ParsedProject { mut units }, index, .. } = indexed_project;
+ for unit in &mut units {
+ array_lowering::lower_literal_arrays(unit, &index, &mut self.id_provider);
+ }
+ // Re-index since we modified the AST (new statements, possible new alloca variables)
+ let project = ParsedProject { units };
+ project.index(self.id_provider.clone())
+ }
+}
+
 impl PipelineParticipantMut for InheritanceLowerer {
  fn pre_index(&mut self, parsed_project: ParsedProject) -> ParsedProject {
  let ParsedProject { mut units } = parsed_project;

compiler/plc_lowering/src/lib.rs

@@ -4,6 +4,7 @@ use plc::{
 };
 use plc_ast::{ast::AstNode, provider::IdProvider};
 
+pub mod array_lowering;
 pub mod control_statement;
 pub mod inheritance;
 pub mod initializer;

compiler/plc_lowering/src/tests.rs

@@ -1,3 +1,4 @@
+mod array_lowering_tests;
 mod inheritance_tests;
 mod initializer_tests;
 mod super_tests;